add lang clarification to translatable attributes section. #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiecrook
commented
Feb 3, 2022
carmacleod
reviewed
Feb 3, 2022
carmacleod
approved these changes
Feb 3, 2022
Contributor
carmacleod
left a comment
There was a problem hiding this comment.
+1 as-is, but might be a bit clearer if we insert the word "attribute" before "value".
Co-authored-by: Carolyn MacLeod <[email protected]>
MelSumner
approved these changes
Feb 24, 2022
Contributor
MelSumner
left a comment
There was a problem hiding this comment.
Thank you for working on this. 👍
jnurthen
approved these changes
Mar 8, 2022
jnurthen
added a commit
that referenced
this pull request
Oct 10, 2023
* add lang clarification to translatable attributes section. Resolves #1365 * Removing accidental whitespace line break * editorial nit * carmacleod suggestion: 'value' -> 'attribute value' Co-authored-by: Carolyn MacLeod <[email protected]> * Change references Co-authored-by: Carolyn MacLeod <[email protected]> Co-authored-by: James Nurthen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1365
Preview | Diff