[css-typed-om] Renamed 'flex' base type to 'fraction' #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <flex> data type got moved to CSS Values 5 and renamed to <fraction>. So this adjustment also needed to be done in CSS Typed OM.
|
Did this ship anywhere yet? |
Hm, looks like Chromium and WebKit already support Sebastian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<flex>data type got generalized and moved to CSS Values 5 and renamed to<fraction>in w3c/csswg-drafts#9516.So this adjustment also needs to be done in CSS Typed OM.
(Note that the type was renamed to 'fraction' to better distinguish it from Flexbox, because of the unit being called
fr, and due to it getting more use cases outside of flexible grid track widths.)Sebastian