fix "Queue a task" / "in parallel" usage #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
requested changes
Jan 28, 2022
marcoscaceres
commented
Jan 28, 2022
|
Seriously, thanks for going over it @reillyeon! 🙏 Sorry again about all the changes 😅. But... I.... I THINK WE ARE CR READY!!!! 🎉🎉🎉 🍾🥂 |
Co-authored-by: Reilly Grant <[email protected]>
7de85ef to
3453a23
Compare
reillyeon
approved these changes
Jan 28, 2022
reillyeon
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114
Closes #113
Really sorry folks, this ended needing more changes than I had initially hoped (I found some additional bugs).
@reillyeon, um, I don't expect you to review all this... I'm wonder if we should just take it, and then do a "full spec review"?
How should we proceed?
Preview | Diff