Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@NavidZ
Copy link
Member

@NavidZ NavidZ commented Aug 6, 2019

@NavidZ
Copy link
Member Author

NavidZ commented Aug 6, 2019

@smaug---- @BoCupp-Microsoft @graouts @patrickhlauke any feedback is appreciated.
This feature was already implemented/shipped in Chrome like 2 years ago and you can give it a try there if you like.

@plehegar, @patrickhlauke I changed the PE level to version 3 in this pull request and added links and whatnot to PEv2. Let me know if we are planning it some other way or whether it is alright from W3C point of view to have it like this. I assumed the published version of V2 is already hosted as an html file and has nothing to do with the top commit of this repo. So we can just change the code here and move to the V3. But feel free to correct me if I'm wrong. I can change this PL to whatever you suggest.

@patrickhlauke patrickhlauke changed the base branch from gh-pages to pe3 August 6, 2019 22:04
@patrickhlauke
Copy link
Member

changed this to use pe3 as base branch - just so we can work on integrating the extension stuff and touch action values etc into it and then plop the v3 rough version into gh-pages in one fell swoop (not that it makes much of a difference i guess)

@patrickhlauke patrickhlauke changed the base branch from pe3 to gh-pages August 7, 2019 15:37
@patrickhlauke
Copy link
Member

discussed in PEWG call today, no point working separately in pe3 branch. we'll just do it straight in gh-pages...

@NavidZ
Copy link
Member Author

NavidZ commented Aug 16, 2019

@smaug---- @BoCupp-Microsoft @graouts any objections/comments regarding the new values? Can we merge this PR as is?

@patrickhlauke patrickhlauke self-requested a review August 29, 2019 15:49
@patrickhlauke patrickhlauke merged commit 8ba4ba4 into w3c:gh-pages Aug 29, 2019
@NavidZ
Copy link
Member Author

NavidZ commented Aug 29, 2019

@graouts this seems to be merged now. But feel free to still review the change and we can still incorporate your feedback if you don't agree with the current proposal.

@patrickhlauke
Copy link
Member

oh sorry, i just assumed that since @graouts' comment was only related to the out-of-scope changes in this PR, that he was ok with the rest. if that wasn't the case, apologies Antoine

@graouts
Copy link

graouts commented Aug 30, 2019

No worries, you assumed correctly.

NavidZ added a commit to NavidZ/pointerevents that referenced this pull request Nov 11, 2019
Remove the extension doc now that the content of it
has been merged into the main spec as part of the
following pull requests:

w3c#307
w3c#306
w3c#294
@NavidZ NavidZ mentioned this pull request Nov 11, 2019
@mustaqahmed
Copy link
Member

We already have the following WPTs covering this PR: pointerevent_touch-action-pan-{left,right,up,down}-css_touch.html.

@mustaqahmed mustaqahmed removed the wpt label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants