Expand explanation for non-coalesced events #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a user agents may coalesce events not just if the position is updated, but any of the attributes (as it's not just position changes that can result in an overwhelmingly large number of events) - tweaked the matching sentence in the `pointerrawupdate` slightly, to use `pointer's attributes` rather than the awkward sounding `pointing device attributes` Closes #375
7c914c8 to
4d86bc5
Compare
- includes glossary definition for discrete and coalesced properties
mustaqahmed
reviewed
Jun 9, 2021
…nstead due to the fact that `tiltX`, `tiltY`, `twist` being `long` properties would count as discrete under the general definition.
Member
Author
|
@flackr @smaug---- if you could have a look at this so far. it's not super elegant, but hopefully accurate at least. open to any better suggestions too of course. |
mustaqahmed
reviewed
Jun 10, 2021
Member
mustaqahmed
left a comment
There was a problem hiding this comment.
The glossary entry looks good to me but please wait for a second opinion because I may be biased towards "measurable".
…ogether no need to mention them, as they don't lead to pointer events firing anyway
mustaqahmed
approved these changes
Jun 10, 2021
Member
mustaqahmed
left a comment
There was a problem hiding this comment.
LGTM, thanks,
I would still suggest a second review in case I am too biased towards "measurable".
smaug----
approved these changes
Jun 23, 2021
Contributor
smaug----
left a comment
There was a problem hiding this comment.
I would possibly just drop that "domain" thing
mustaqahmed
reviewed
Jun 23, 2021
smaug----
approved these changes
Jul 7, 2021
flackr
approved these changes
Jul 7, 2021
Member
Author
|
Agreed on call to add "continuous" as per #379 (comment) (first option) and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointerrawupdateslightly, to usepointer's attributesrather than the awkward soundingpointing device attributesin contrast with>in contrast toCloses #375
Preview | Diff