Proposal for typescript definition file#265
Merged
Merged
Conversation
Now ts definition file supports both module and no module system environments.
zolkis
approved these changes
Sep 23, 2020
danielpeintner
approved these changes
Sep 24, 2020
Contributor
|
I published it as "0.8.0-SNAPSHOT.2" on npm. Moreover, I also updated v0.8.x branch of node-wot but I did run into issues like
Currently we use the following which does not work anymore.
@relu91 Can you let me know how it is assumed to work. Thanks! Note: The TS definitions still miss the new Subscription (I will add/update once the issues are resolved). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally found a solution to have our typescript definition file work both in module and no-module environments. Practically this means that
tscwill validate both of those code snippets:As a example the first one might be written inside WoT scripts (which may not support a module system) and the latter for runtimes who want to use node-wot as a library.
Since I had to format the file it is quite difficult to undestand the change. Essentially I changed the declaration of the namespace from
export as namespace WoT;to:Finally I exposed every field in the namespace as a module with the following:
I created a PR since I think this is the final solution.
Fixes #215 .