Add basic sudo support - #50
Merged
Merged
Conversation
houndci-bot
reviewed
Feb 18, 2018
|
|
||
| } | ||
|
|
||
| func StoreSudoPasswd() { |
There was a problem hiding this comment.
exported function StoreSudoPasswd should have comment or be unexported
houndci-bot
reviewed
Feb 18, 2018
|
|
||
| } | ||
|
|
||
| func StoreSudoPasswd() { |
There was a problem hiding this comment.
exported function StoreSudoPasswd should have comment or be unexported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #37 , this captures a user's password and attempts to run flagged commands with sudo (and automatically provide the password). This will not work for tailored sudoers files for particular commands since this is testing against
/bin/truefor the need to ask for credentials... so it is possible for bashful to not ask for a sudo password when one will be needed during execution (leaving bashful running forever as a subprocess is waiting for user input). Even with this pitfall, this is probably 'good enough' for now.