Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update 3rd party libraries - #8775

Open
nicosomb wants to merge 1 commit into
masterfrom
update-dependencies
Open

Update 3rd party libraries#8775
nicosomb wants to merge 1 commit into
masterfrom
update-dependencies

Conversation

@nicosomb

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
CHANGELOG.md no
License MIT

Fix #5689

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (43e13a3) to head (4c88cbf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #8775   +/-   ##
=========================================
  Coverage     91.12%   91.12%           
  Complexity     1988     1988           
=========================================
  Files           175      175           
  Lines          7009     7009           
=========================================
  Hits           6387     6387           
  Misses          622      622           
Flag Coverage Δ
functional 76.39% <ø> (ø)
integration 20.54% <ø> (ø)
unit 25.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yguedidi yguedidi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for maintainability I would instead generate this list from composer.json and package.json directly in some ways, so that we don't have to maintain this static list manually.
we can warm up the computed list in the cache in case it's heavy to compute but may be not needed

@nicosomb

nicosomb commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

Your idea is good (i had it but I thought it was overkill).

But in fact, I wonder if we have to keep this section ... is that necessary to have it? Is that useful?

Maybe we can remove it.

@yguedidi

yguedidi commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Maybe we can keep it but making it point to the composer.lock and yarn.lock files on github, ideally taking care of the right tag of the current version in the URL?

@Kdecherf

Kdecherf commented May 2, 2026

Copy link
Copy Markdown
Member

Hello @nicosomb @yguedidi,

I may have an idea in between.

What about replacing this list with a link to a tag-based documentation page on the github repository, for example https://github.com/wallabag/wallabag/blob/master/doc/content/developer/_index.md, replacing master with a release tag, and _index.md with the actual page we would like to put).

Then, the documentation page could be automatically generated when creating a new release, by extracting packages from the lock files.

Any thoughts?

@yguedidi

yguedidi commented May 5, 2026

Copy link
Copy Markdown
Contributor

@Kdecherf first thoughts is that if anyway we have to build an extraction logic, then I'd prefer to have it in the app like now.

@Kdecherf

Kdecherf commented May 5, 2026

Copy link
Copy Markdown
Member

@yguedidi what would be the value of having this logic within the app instead of the documentation?

@yguedidi

yguedidi commented May 5, 2026

Copy link
Copy Markdown
Contributor

@Kdecherf I'd say consistent with current location, but the biggest value to me would be to not have to manage multiple versions of that doc, as it will come directly from the wallabag instance of the user at the version they use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update about page

4 participants