Replace JavaScript-only action links with semantic controls - #8978
Draft
yguedidi wants to merge 20 commits into
Draft
Replace JavaScript-only action links with semantic controls#8978yguedidi wants to merge 20 commits into
yguedidi wants to merge 20 commits into
Conversation
Replace the primary Materialize navigation action link with a native button while retaining its controller hookup and toggle behavior. This establishes the semantic-control pattern at the navigation boundary. Remaining navigation trigger variants stay as adjacent fixups so reviewers can assess each migration slice independently.
…avigation panel controls Move the reader sidenav and account-menu triggers onto the established button pattern. These are the remaining navigation-panel variants, so they stay adjacent to the seed rather than becoming a second navigation change.
…ilter and export controls Convert the filter and export panel triggers to semantic buttons while preserving their target wiring. They use the same mechanical replacement as the seed and are grouped for one focused follow-up review.
…responsive control styling Keep the converted main navigation trigger visually consistent in the responsive and dark-theme navigation styles. The styling is derivative of the button migration, so it remains attached to that seed.
Replace the topbar mode trigger with a native button while keeping the existing Stimulus mode transition intact. The topbar has a distinct interaction model, so its semantic conversion is reviewed separately from navigation triggers.
…search close controls Convert the close controls used by the add URL and search modes to native buttons. They complete the same topbar pattern and remain an adjacent fixup for focused review.
…ior and styling Retain the close-button icon layout after the semantic element change. This visual adjustment is inseparable from the converted topbar control and stays a fixup.
Convert the shared theme-selection actions to native buttons without changing the theme controller contract. Theme selection is a separate control family and can be reviewed independently from topbar modes.
…heme controls Apply the established theme-button pattern to reader-specific theme actions. These controls share the seed behavior and remain grouped as its follow-up.
…lize dropdown behavior Preserve dropdown, sidenav, and dark-theme styling for converted theme controls. The style changes are derivative of the theme conversion and belong in its fixup block.
Convert the primary reader action control to a native button while retaining the existing disclosure wiring. Reader actions have their own interaction surface, so this seed stays separate from topbar and theme controls.
…nd floating actions Convert theme, share, and floating reader disclosures to the established button pattern. These controls complete the same reader-action migration and remain together for a focused follow-up review.
…rt and print actions Convert the remaining export and print reader actions to native buttons. They use the seed pattern and stay in its fixup block instead of creating a second reader action story.
…-click protection Remove Materialize keyboard handling that duplicates native button activation. This is a compatibility correction to the reader button conversion and belongs with its seed.
Replace the initial configuration help trigger with a native button while preserving the tooltip controller contract. Configuration help is a separate control family and is intentionally isolated for review.
…ooltip triggers Apply the configuration-help button pattern to the remaining article-display tooltip triggers. They are equivalent migrations, so this stays as the seed follow-up.
…-control dimensions Keep tooltip icon alignment and line-height stable after the native button conversion. The CSS adjustment is a direct completion of the configuration-help seed.
Add a repository-wide Twig anchor guard that rejects anchors without real destinations. This establishes the semantic regression boundary after the button migrations; specialized invalid destinations follow as fixups.
…are fragment destinations Reject bare hash destinations in Twig anchors. This narrows the seed validation with one concrete invalid-link form, so it remains a fixup.
…ly the intentional bookmarklet Reject JavaScript destinations while retaining the known static bookmarklet exception. The exception refines the same anchor guard and belongs in its fixup block.
✅ Deploy Preview for wallabag-doc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle ReportChanges will increase total bundle size by 14.75kB (0.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: wallabag-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8978 +/- ##
=========================================
Coverage 91.46% 91.46%
Complexity 2012 2012
=========================================
Files 178 178
Lines 7144 7144
=========================================
Hits 6534 6534
Misses 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8967.
Replace JavaScript-only action links and role=button icons with native buttons while preserving navigational anchors, Materialize hooks, and UI parity. This is the semantic-control foundation for the accessibility layer above it.
This draft is easiest to review one commit at a time; its descriptive fixups intentionally remain visible.