Use readable-stream and fix the problem for angular users #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦tring" This reverts commit 1ad98a0.
β¦t includes iam bug fixes
β¦I keys and credentials and added URL parameters
β¦ce urls if those were set
β¦on to mention all required dependencies feat: Added support for IAM API tokens to python server
Added microphone-stream.js Added microphone-stream.js Fixed a few issues with PR quality related Fixed a few issues with PR quality related Fixed a few issues with PR quality related Removed microphone-stream.js and using from node module itself chore: Add 'path' and 'readable-stream' Update existing dependencies
β¦ascript-sdk into fix-angular
dpopp07
approved these changes
Apr 5, 2019
Contributor
dpopp07
left a comment
There was a problem hiding this comment.
Looks great, thanks German
|
π This PR is included in version 0.35.10 π The release is available on: Your semantic-release bot π¦π |
|
Still seeing the issue with ng 8 #103 Module not found: Error: Can't resolve 'watson-speech/speech-to-text/recognize-microphone' |
|
npm i watson-speech@latest works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103 and could also solve the problem with #83.
I made a mistake with the rebase so we should squash this with a
fix: Add support for Angularcommit message