All committers have signed the CLA.

@mingzhi22 why?

@mingzhi22 why?

   var indexSampleAfterLastUsed = Math.round(samplingRateRatio * i); // 'i' is out of range
   var remaining = buffer.length - indexSampleAfterLastUsed;
   if (remaining > 0) { // 'remaining' is always less than 0

I'll let @dpopp07 decide

Hi @mingzhi22
I admit, I don't fully understand the DSP behind this code. By looking at it mathematically, I can see that you are correct that

1. i will be out of range by the end of the loop and
2. remaining will always be less than 0

However, I am not fully convinced that your fix is what we want (probably because of my lack of understanding), although it certainly solves the "out of range" problem.

Could you please post your use-case, an example, or just an explanation of why you are changing the loop to end at outputBuffer.length? I just don't want to commit code I don't understand. Thanks

// remaining will equal 1 when 1st call downsample, equal 2 when 2nd call downsample.
for (i = 0; i < outputBuffer.length; i++) {

// i will be out of range, remaining will always be less than 0
for (i = 0; i + filter.length - 1 < buffer.length; i++) {

I'm not sure this change is correct. The first loop needs to iterate over the elements in the output buffer, since it is producing the output samples from the input samples. Also, are you sure i will be out of range?

I'm not sure this change is correct. The first loop needs to iterate over the elements in the output buffer, since it is producing the output samples from the input samples. Also, are you sure i will be out of range?

Hi @daniel-bolanos.

The capacity of outputBuffer is 1479, but i is 4076.

hi @dpopp07 @daniel-bolanos, here is my user-case. Download and run npm install && npm run build && npm start to start.

downsample.zip

@mingzhi22 sorry for the delay I didn't see your comment before.

@dpopp07 can you check if running the audio from @mingzhi22 you run in the out of bound exception?

@mingzhi22
I used webaudio-l16-stream to creating a WAVE file, but the file has some noises.
It becomes very clear sound when applied your PR patch.

Thanks!

🎉 This PR is included in version 0.35.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀