fix(Express): properly format basic auth creds #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, some object shorthand was being done, which caused the credential object to be improperly nested under a "token" key. this caused the frontend code to pass an object instead of the actual api key, which broke all websocket connections.
previously, just a string 'fakeToken' was returned, which is mismatched with the current expected token object structure. this returns the actual fakeToken object that is declared in the test.
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, some object shorthand was being done, which caused the credential object to be
improperly nested under a "token" key. this caused the frontend code to pass an object instead of
the actual api key, which broke all websocket connections.
@germanattanasio as we discussed. if you can review quickly i'd appreciate it as this bug is causing issues in the live demo. thanks 👍