add 4 more fill colors#262
Merged
Merged
Conversation
Member
|
@hlyi please explain the reason for this change. |
Contributor
Author
|
For diagrams with a lot signals, more fill colors can demonstrate different conditions better and avoid confusions |
Member
|
@hlyi sounds good. Skin files should be generated from SVG sources here: https://github.com/wavedrom/wavedrom/tree/master/unpacked/skins Here is an instruction: https://github.com/wavedrom/wavedrom/tree/master/unpacked |
Contributor
Author
|
@drom Just update svg and skins js per your instruction. Could you please check? |
Member
|
LGTM |
Member
|
@hlyi Thank you for your contribution. It is up and running on the https://wavedrom.com |
Contributor
Author
|
@drom Thanks for taking the patch. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 4 more fill colors
'6' = light-cyan: class 26
'7' = light-green: class 27
'8' = light-purple: class 28
'9' = light-red : class 29.
Change classes of existing fill colors to make it more consistent with classes of new fill colors
'2' from class 10 to class 22
'3' from class 6 to class 23
'4' from class 7 to class 24
'5' from class 8 to class 25.