Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show Caps Lock indicator in SSH password prompt - #2840

Open
0John-Hong0 wants to merge 5 commits into
wavetermdev:mainfrom
0John-Hong0:ssh-password-capslock
Open

Show Caps Lock indicator in SSH password prompt#2840
0John-Hong0 wants to merge 5 commits into
wavetermdev:mainfrom
0John-Hong0:ssh-password-capslock

Conversation

@0John-Hong0

@0John-Hong0 0John-Hong0 commented Feb 8, 2026

Copy link
Copy Markdown

When entering an SSH password, there is no indication if Caps Lock is enabled, which can lead to failed attempts.

This adds a small Caps Lock indicator to the SSH password input.
The change is scoped only to the password prompt and does not affect behavior.

@CLAassistant

CLAassistant commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request adds Caps Lock detection functionality to the user input modal component. A new state variable tracks whether Caps Lock is active, with event handlers on onKeyDown and onKeyUp that detect the Caps Lock status. When Caps Lock is detected and the input is not in public text mode, a warning message displays below the input field. The changes also include minor formatting adjustments to the checkbox label element and updated useEffect dependencies to include the new handler function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a Caps Lock indicator to the SSH password prompt.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation, what was added, and the scope of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
frontend/app/modals/userinputmodal.tsx (1)

82-84: Nitpick: ?? false is redundant on getModifierState.

getModifierState() always returns a boolean, never null or undefined, so the nullish coalescing is unnecessary.

🔧 Suggested simplification 
 const handleCapsLockCheck = useCallback((e: React.KeyboardEvent<HTMLInputElement>) => {
-    setCapsLockOn(e.getModifierState("CapsLock") ?? false);
+    setCapsLockOn(e.getModifierState("CapsLock"));
 }, []);

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PhenixStar PhenixStar mentioned this pull request Mar 15, 2026
Merged
7 tasks
tobiashochguertel added a commit to tobiashochguertel/waveterm that referenced this pull request Aug 23, 2026
@tobiashochguertel @devin-ai-integration
feat: integrate 4 SSH improvement PRs via .patch
e4d9885 
- wavetermdev#3421: ssh agent forwarding (ForwardAgent / ssh:forwardagent)
  005-ssh-agent-forwarding.patch — 7 files
- wavetermdev#3460: recover durable SSH sessions stuck falsely-attached
  006-ssh-durable-session-recovery.patch — 6 files
- wavetermdev#3401: wrap agent signers for identity failover on signing failure
  007-ssh-agent-signer-failover.patch — 2 files
- wavetermdev#2840: caps lock indicator in SSH password prompt
  008-ssh-capslock-indicator.patch — 1 file

All 4 patches apply cleanly in sequence (005-008) on top of
existing patches (001-004). Go build, Go tests, and frontend
build all pass. Idempotency verified for all patches.

Updated PATCHED_FILES (16 → 28 files), ALREADY_INTEGRATED,
workflow commit message, and FORK-STRATEGY.md.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
tobiashochguertel added a commit to tobiashochguertel/waveterm that referenced this pull request Aug 23, 2026
@tobiashochguertel @devin-ai-integration
docs: mark 4 SSH PRs as integrated in catalog and strategy
e5d6735 
Update ALREADY_INTEGRATED and PATCHED_FILES for:
- wavetermdev#3421 ssh agent forwarding
- wavetermdev#3460 durable SSH session recovery
- wavetermdev#3401 ssh agent signer failover
- wavetermdev#2840 caps lock indicator

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0John-Hong0 @CLAassistant