Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rewrite run_parser* functions to always return a mod_ty #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2020
Merged

Rewrite run_parser* functions to always return a mod_ty #17

merged 6 commits into from
Mar 24, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Mar 23, 2020 •
edited
Loading

Closes #15.

@lysnikolaou
Rewrite run_parser* functions to always return a mod_ty
128f5fb 
    * The caller is responsible for transforming the mod_ty to
      a code object or an AST object
@lysnikolaou
Merge branch 'pegen' into rewrite-run-parser
292597b
@lysnikolaou
Run clang-format
85e6adf
gvanrossum
gvanrossum reviewed Mar 23, 2020
View reviewed changes
Copy link

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should switch EXTENSION_SUFFIX to be much smaller and move most of that code to a separate file.

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Mar 23, 2020 •
edited by gvanrossum
Loading

I still think we should switch EXTENSION_SUFFIX to be much smaller and move most of that code to a separate file.

I have this almost ready and was thinking of opening a new PR for it. What do you think?

Okay, a separate PR is fine!

gvanrossum
gvanrossum reviewed Mar 23, 2020
View reviewed changes
Copy link

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but I'd still like to see if we can easily drop the filename_ob parameters.

@lysnikolaou
Copy link
Member Author

Better, but I'd still like to see if we can easily drop the filename_ob parameters.

Just pushed a fix for this.

gvanrossum
gvanrossum approved these changes Mar 24, 2020
View reviewed changes
Copy link

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bang!

@lysnikolaou
Copy link
Member Author

Bang!

Yes!

@lysnikolaou lysnikolaou merged commit 14ae717 into pegen Mar 24, 2020
@lysnikolaou lysnikolaou deleted the rewrite-run-parser branch March 24, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite of run_parser* functions
3 participants
@lysnikolaou @gvanrossum @pablogsal