You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi π
I inherited a clojure application where one of the other dependencies now depends on ring/ring-core 1.15.3, compojure prevents that right now. I'm very new to the ecosystem, so I don't know the side effects of updating this lib in your project. I verified locally that lein test passes.
Thanks for the commit. Can you change the commit message to:
Update ring-core dependency to 1.15.3
This makes the commit message more consistent with the rest of the commit history.
Another important note is that in both Leiningen and tools.deps, closer dependencies override further ones. So if you put the [ring/ring-core "1.15.3"] dependency in your ring-middleware project file as part of its direct :dependencies, this will override the version of ring-core specified by Compojure.
In other words, you don't need to wait for a Compojure release β you can just add [ring/ring-core "1.15.3"] to your deps to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi π
I inherited a clojure application where one of the other dependencies now depends on ring/ring-core 1.15.3, compojure prevents that right now. I'm very new to the ecosystem, so I don't know the side effects of updating this lib in your project. I verified locally that
lein testpasses.