MessagePort: implement disentanglement #52130
Merged
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 23, 2025
a8fabba to
2c544f6
Compare
Signed-off-by: gterzian <[email protected]>
2c544f6 to
103a1f6
Compare
|
⛔ The downstream PR has merged (servo/servo#36654), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement disentangle
Remove bespoke gc logic which now becomes unnecessary.
Adds a wpt test that hits the "disentangle while in transfer" logic.
Updates streams code, fixing an error where disentanglement is conditional on an error.
Test coverage: there are existing tests in
/webmessaging/message-channels/close-event/explicitly-closed.tentative.window.jsfor the no transfer case, and the simple completed transfer case, and this PR adds a test for the more complicated transfer in progress case.Fix servo/servo#36465
Reviewed in servo/servo#36654