vt/cc: Speculative fix for a test + DCHECK -> CHECK upgrade #52289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch promotes a DCHECK to a CHECK to diagnose the referenced bug, as well as adds good practice test change as a speculative fix. [email protected] Bug: 413305967 Change-Id: Ic83b68d3e7ea368892f26cabf8c388521db80a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505311 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1454635}
wpt-pr-bot
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch promotes a DCHECK to a CHECK to diagnose the referenced
bug, as well as adds good practice test change as a speculative fix.
R=[email protected]
Bug: 413305967
Change-Id: Ic83b68d3e7ea368892f26cabf8c388521db80a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505311
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1454635}