[vt] Track animations that are pending a DOM callback after being skipped #52358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped Previously calling startViewTransition followed by a second startViewTransition would correctly skip the first and wait on its DOM callback to be triggered; however, since skipping a transition removes it from the active list, starting a VT after an explicit skip could result in the DOM callback of the first getting lumped in with the second. This patch adds tracking of skipped transitions with a pending DOM callback. These are considered "active" from the perspective of blocking the replacement transition's capture phase. Bug: 414396338 Change-Id: Ife841566239e735db46f6006f2391d02d9cf183d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513530 Commit-Queue: Kevin Ellis <[email protected]> Reviewed-by: Steve Kobes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1456270}
wpt-pr-bot
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously calling startViewTransition followed by a second
startViewTransition would correctly skip the first and wait on
its DOM callback to be triggered; however, since skipping a
transition removes it from the active list, starting a VT after an
explicit skip could result in the DOM callback of the first getting
lumped in with the second. This patch adds tracking of skipped
transitions with a pending DOM callback. These are considered
"active" from the perspective of blocking the replacement
transition's capture phase.
Bug: 414396338
Change-Id: Ife841566239e735db46f6006f2391d02d9cf183d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513530
Commit-Queue: Kevin Ellis <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1456270}