Fix incorrect cache key for draw transforms #52370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the presence of surface_contents_scale which may vary by effect node (even under the same transform space--different layers can have different content scales), it's not sufficient to check that the target transform id is the same when computing draw transforms. Instead check the effect node. Bug: 414940070 Change-Id: I20ebdbe46ebd0a87acc88ca0643618c7abb049f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514595 Commit-Queue: Chris Harrelson <[email protected]> Reviewed-by: Vasiliy Telezhnikov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1456478}
wpt-pr-bot
approved these changes
May 6, 2025
cc8aa9c to
7767606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the presence of surface_contents_scale which may vary by effect
node (even under the same transform space--different layers can
have different content scales), it's not sufficient to check that
the target transform id is the same when computing draw transforms.
Instead check the effect node.
Bug: 414940070
Change-Id: I20ebdbe46ebd0a87acc88ca0643618c7abb049f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514595
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1456478}