fix base64encode issue #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minishlink
requested changes
Mar 7, 2019
added 2 commits
March 8, 2019 15:33
Minishlink
requested changes
Mar 8, 2019
|
hmm ... |
|
Yes it's a phpstan bug that has been fixed, I'll merge your pr this week-end :) |
|
great ~~ thank |
marcvdm
pushed a commit
to level23/web-push-php
that referenced
this pull request
Jun 14, 2019
* fix base64encode issue * typo ~ fix Base64Url::encode * fix phpunit testing * fix The condition becomes ">=86" and ">=42"
marcvdm
pushed a commit
to level23/web-push-php
that referenced
this pull request
Jun 14, 2019
* fix base64encode issue * typo ~ fix Base64Url::encode * fix phpunit testing * fix The condition becomes ">=86" and ">=42"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to
base64encode could be generate "="
recommend to change base64urlencode to avoid this issue