This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix(docs): contract-tutorial #7075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 89cf4a0 | Previous: 8f62749 | Ratio |
|---|---|---|---|
processingTx |
9187 ops/sec (±4.53%) |
8813 ops/sec (±4.63%) |
0.96 |
processingContractDeploy |
40283 ops/sec (±6.66%) |
35202 ops/sec (±8.08%) |
0.87 |
processingContractMethodSend |
19484 ops/sec (±6.37%) |
17884 ops/sec (±5.35%) |
0.92 |
processingContractMethodCall |
39536 ops/sec (±3.94%) |
34262 ops/sec (±7.43%) |
0.87 |
abiEncode |
43401 ops/sec (±7.95%) |
38844 ops/sec (±8.37%) |
0.90 |
abiDecode |
30878 ops/sec (±6.74%) |
26526 ops/sec (±8.50%) |
0.86 |
sign |
1577 ops/sec (±0.79%) |
1546 ops/sec (±0.88%) |
0.98 |
verify |
372 ops/sec (±0.53%) |
353 ops/sec (±0.78%) |
0.95 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7075 +/- ##
==========================================
+ Coverage 87.37% 93.98% +6.61%
==========================================
Files 197 215 +18
Lines 7548 8335 +787
Branches 2059 2301 +242
==========================================
+ Hits 6595 7834 +1239
+ Misses 953 501 -452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9d8a2f4 to
e5c3d53
Compare
- Ganache has been deprecated, use Hardhat - Use JavaScript instead of TypeScript - Improvements (more links, formatting/consistency) and simplifications
e5c3d53 to
2ec2238
Compare
avkos
approved these changes
Jun 4, 2024
luu-alex
approved these changes
Jun 4, 2024
jdevcs
approved these changes
Jun 5, 2024
|
Closing in favor of #7076 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an ephemeral Hardhat development network and would replace #7076