Conversation
Member
|
Before we start the review process, let's be sure to rebase against master -- I think a few PRs have landed there. |
…review. Now we show it on the containing <div>.
Fixes #2310 - remove XML declaration
Fixes #2312 - remove href from button
Fixes #2317 - remove gray border of sub-nav
Fixes #2319 - remove unused css class in js
Fixes #2324 - add js class to separate css and js functionality
Fixes #2204 - add license info of new icon set
Fixes #2216 - add screenshots
Member
|
Need to investigate why tests are failing now. |
Member
|
I think something is wacky on travis, i'm going to nuke the build cache and restart.
Still failed, but tests are running and passing locally, so I'm not super concerned. |
Member
Author
|
I had that issue too, but it disappeared after restarting the build |
Member
|
And tests decided to start passing again, yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets see how bad it really is...