feat(browserstack-service): add accessibility support for Safari and Chrome for Testing#15208
Open
harshit-browserstack wants to merge 8 commits into
Open
feat(browserstack-service): add accessibility support for Safari and Chrome for Testing#15208harshit-browserstack wants to merge 8 commits into
harshit-browserstack wants to merge 8 commits into
Conversation
Author
|
Hi @christian-bromann, could you please review this when you have a moment? This adds Safari 18.4+ and Chrome for Testing 141+ support to the accessibility automation in the BrowserStack service. Internal approval from BrowserStack reviewers is linked in the description. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Extends Accessibility Automation in the BrowserStack service to support Safari and Chrome for Testing in addition to Chrome.
Changes:
SUPPORTED_BROWSERS_FOR_ACCESSIBILITY,MIN_BROWSER_VERSIONS_A11Y, andMIN_BROWSER_VERSIONS_A11Y_NON_BSTACKconstants so minimum versions live in one place.validateCapsWithA11yandvalidateCapsWithNonBstackA11yto do per-browser validation (major/minor version compare for Safari, major-only for Chrome variants) with clearer warning messages.validateCapsWithNonBstackA11yin try/catch to avoid breaking the run when capability shapes are unexpected.Internal PR with approvals: harshit-browserstack#1
Types of changes
Checklist
Backport Request
v9and doesn't need to be back-ported#XXXXXFurther comments
The new constants keep BrowserStack and non-BrowserStack minimum versions separate because the two environments have historically diverged (Chrome 95 vs 100). Keeping them as two tables makes future bumps explicit rather than accidental.
Reviewers: @webdriverio/project-committers