-
Notifications
You must be signed in to change notification settings - Fork 55
Replace MLActivation with MLRecurrentNetworkActivation #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@huningxin PTAL? |
huningxin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Please merge at your convenience (I don't have write access). Thanks! |
fdwr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Conflicts resolved! Merge at your convenience 🙏 |
fdwr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
SHA: 487a992 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041}
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041}
Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041}
According to spec change: webmachinelearning/webnn#718
According to spec change: webmachinelearning/webnn#718
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
…rentNetworkActivation, a=testonly Automatic update from web-platform-tests webnn: Replace MLActivation with MLRecurrentNetworkActivation Implements the changes from this spec PR: webmachinelearning/webnn#718 Bug: 351866391 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I163c85af63468a2ad4166509196ac3734d379df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334041} -- wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77 wpt-pr: 47325
As proposed in #689 (comment)
An
MLRecurrentNetworkActivationenum is sufficient for describing activation functions passed to recurrent operators likelstmandgruPreview | Diff