Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@a-sully
Copy link
Contributor

@a-sully a-sully commented Jul 8, 2024

As proposed in #689 (comment)

An MLRecurrentNetworkActivation enum is sufficient for describing activation functions passed to recurrent operators like lstm and gru


Preview | Diff

@a-sully
Copy link
Contributor Author

a-sully commented Jul 10, 2024

@huningxin PTAL?

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-sully
Copy link
Contributor Author

a-sully commented Jul 11, 2024

Please merge at your convenience (I don't have write access). Thanks!

@huningxin huningxin requested a review from fdwr July 12, 2024 03:17
@inexorabletash
Copy link
Contributor

inexorabletash commented Jul 17, 2024

FYI this will need rebasing on top of dbb9d1c - f08f9f7 - mostly just deletions though. Once that's done, lint is happy.

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-sully
Copy link
Contributor Author

a-sully commented Jul 22, 2024

Conflicts resolved! Merge at your convenience 🙏

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 487a992 into webmachinelearning:main Jul 22, 2024
github-actions bot added a commit that referenced this pull request Jul 22, 2024
SHA: 487a992
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@a-sully a-sully deleted the fix-689 branch July 23, 2024 12:57
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}
huningxin added a commit to huningxin/webnn-samples that referenced this pull request Jul 29, 2024
Honry pushed a commit to webmachinelearning/webnn-samples that referenced this pull request Jul 29, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 31, 2024
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 5, 2024
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants