Improve source-map addon: safely enable sourceMap in tsconfig with JSON parsing and fallback#10
Open
Manas-Dikshit wants to merge 1 commit intowebpack:mainfrom
Open
Improve source-map addon: safely enable sourceMap in tsconfig with JSON parsing and fallback#10Manas-Dikshit wants to merge 1 commit intowebpack:mainfrom
Manas-Dikshit wants to merge 1 commit intowebpack:mainfrom
Conversation
Refactor setup and teardown functions to handle sourceMap option in tsconfig.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the addons/source-map.js script for better robustness and maintainability.
Changes Made
Safe JSON parsing for the tsconfig.json file before it's updated.
CompilerOptions creation if it does not exist.
Cleaner usage of regex for falling back on JSON parsing.
Consistent JSON formatting for the tsconfig.json file.
Simplified the code with only the most important comments.
Why
The original code only used regex replacement, which could result in an incorrect tsconfig.json file, especially if the JSON formatting was different.
This updated code ensures that the JSON output is always valid, providing a better experience for the user.
Result
The updated addon successfully adds "sourceMap": true to compilerOptions and then reverts the changes on teardown.