improvements to ESM support, module library, import chunk loading, module externals
#13622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
b6b94a7 to
a43edfd
Compare
add test cases for `experiments.outputModule`
a43edfd to
4da99d8
Compare
| D( | ||
| output, | ||
| "hotUpdateChunkFilename", | ||
| `[id].[fullhash].hot-update.${output.module ? "mjs" : "js"}` |
There was a problem hiding this comment.
Maybe we can read package.json here and use js when "type": "module" (same for filename)?
module library, import chunk loadingmodule library, import chunk loading, module externals
… externals for `module` externals, fallback to `import()` when not in module mode
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
I've created an issue to document this in webpack/webpack.js.org. |
7 tasks
This was referenced Jun 29, 2021
This was referenced Jun 30, 2021
Jack-Works
reviewed
Jul 25, 2021
| @@ -0,0 +1,16 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
I cannot let my webpack 5.46 emit import(...) with this config. Is this feature released?
There was a problem hiding this comment.
Oh sorry I forgot to export config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
output.library.type: "module"is now experimentally supportedoutput.chunkLoading: "import"usesimport()to load chunksoutput.chunkFormat: "module"uses ESM exports to expose chunk dataexperiments.outputModulewill now useoutput.chunkFormat: "module", output.chunkLoading: "import"externalsType: "module"generates nowimport * as X from "..."(in a module) orimport("...")(in a script)externalsType: "node-commonjs"generatesimport { createRequire } from "module"when in a moduleexternalsPresetsusenode-commonjsnow when node.js related