Closed
Conversation
Contributor
|
For maintainers only:
|
| const modulesExcludeFromURL = []; | ||
| /** @type {Map<string, {modules: CssModule[], entry?: CssModule}>} */ | ||
| const URLRequestModulesMap = new Map(); | ||
| for (const module of modules) { |
Contributor
Author
There was a problem hiding this comment.
I want collect all modules from a new URL if we want to support @import for new URL
Member
There was a problem hiding this comment.
I think we need to search another approach... I will try to find time on this, you can keep it as is right now
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Also need to fix tests
chore: lint update chore: update chore: asset filename snapshot
4d37d9e to
1dd52da
Compare
Member
|
Close in favor #20131, anyway thank you for your work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?