feat: implement Object.defineProperty support and optimize regex generation #19999
+42
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements missing Object.defineProperty support in CommonJS export requires, optimizes regex generation performance, and fixes a grammar error in documentation.
Motivation: While exploring the webpack codebase, I found a TODO comment that threw an error for Object.defineProperty cases in CommonJS re-exports, plus opportunities for performance optimization and documentation improvements.
Changes:
CommonJsExportRequireDependency(replaces TODO that threw runtime error)compileBooleanMatcherusing character ranges for better performanceWhat kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Additional Notes
All changes are backward compatible and follow existing webpack code patterns. The Object.defineProperty fix prevents runtime errors, the regex optimization improves performance, and the grammar fix improves documentation quality.