fix(sharing): copy buildMeta and buildInfo to ConsumeSharedModule #20054
+103
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConsumeSharedModule now inherits buildMeta and buildInfo from its fallback module to preserve ESM/CJS detection and export analysis metadata. This fix ensures that Module Federation correctly handles ESM modules (particularly .mjs files) by preserving the exportsType and other critical metadata through the consumption chain. The finishModules hook (stage 10) is used to copy metadata after export analysis is complete, following webpack's DelegatedModule pattern. Fixes webpack#16125
|
Would appreciate your review 🙏🏻 @alexander-akait @ScriptedAlchemy (ty ty) |
CodSpeed Performance ReportMerging #20054 will degrade performances by 17.44%Comparing Summary
Benchmarks breakdown
|
|
FYI I verified this fixes "federation-local" case in the new repro I created (#16125 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
Yes
Summary
This PR fixes issue #16125 where
ConsumeSharedModuledoesn't properly inheritbuildMetaandbuildInfofrom its fallback module, causing incorrect ESM/CJS detection for.mjsfiles in Module Federation.Changes
finishModuleshook inConsumeSharedPluginto copybuildMetaandbuildInfofrom fallback modules toConsumeSharedModuleinstancesFlagDependencyExportsPlugin)DelegatedModulepattern for metadata inheritanceTest Coverage
test/configCases/sharing/consume-mjs-module/to verify ESM module consumption works correctlyImpact
This fix ensures Module Federation correctly handles ESM modules (particularly
.mjsfiles) by preserving theexportsTypeand other critical metadata through the consumption chain. This resolves issues with packages likeswr/infiniteand any other shared packages that use.mjsextensions.Related
buildMetaandbuildInfoonConsumeSharedPluginusing fallbacks module-federation/core#4063Does this PR introduce a breaking change?
No