Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement deprecate flag to schema#20432

Draft
bjohansebas wants to merge 9 commits intowebpack:mainfrom
bjohansebas:deprecated-options
Draft

feat: implement deprecate flag to schema#20432
bjohansebas wants to merge 9 commits intowebpack:mainfrom
bjohansebas:deprecated-options

Conversation

@bjohansebas
Copy link
Member

Summary

As discussed on Discord, so that the autogenerated documentation can show that a certain property is deprecated.

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

🦋 Changeset detected

Latest commit: a2ccd54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to improve our types generator to generate @deprecated

package.json Outdated
"tinybench": "^5.0.0",
"toml": "^3.0.0",
"tooling": "webpack/tooling#v1.24.5",
"tooling": "bjohansebas/tooling-webpack#deprecated-linter",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s just for testing :), once it works I’ll send the PR to tooling.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 8, 2026

Merging this PR will degrade performance by 51.6%

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 138 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory benchmark "context-esm", scenario '{"name":"mode-production","mode":"production"}' 10.1 MB 8.2 MB +23.23%
Memory benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 333.6 KB 689.3 KB -51.6%
Memory benchmark "asset-modules-source", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 389.1 KB 620.6 KB -37.31%
Memory benchmark "context-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 664.6 KB 1,068.1 KB -37.77%
Memory benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}' 7.5 MB 9.6 MB -22.34%
Memory benchmark "css-modules", scenario '{"name":"mode-production","mode":"production"}' 9.7 MB 7.6 MB +28.45%

Comparing bjohansebas:deprecated-options (a2ccd54) with main (4098902)

Open in CodSpeed

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think we need to add @deprecated to your types too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants