getSize to return sum of all CSS sizes when no type specified#20518
Open
scameron wants to merge 1 commit intowebpack:mainfrom
Open
getSize to return sum of all CSS sizes when no type specified#20518scameron wants to merge 1 commit intowebpack:mainfrom
scameron wants to merge 1 commit intowebpack:mainfrom
Conversation
|
Member
alexander-akait
left a comment
There was a problem hiding this comment.
/cc @xiaoxiaojx What do you think about it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently getSize on a CSS module will return 1 unless you pass in "css" explicitly as type. This change will return the sum total JS + CSS size when no type is specified.
Resolves #20495.