refactor: rename --config-registered to --disable-interpret

webpack · snitin315 · Jul 25, 2022 · Jul 6, 2022 · Jul 8, 2022 · Jul 8, 2022
commit 79f61c99e75c4742666c5512c2bc467bdefb7ca1
@@ -8,7 +8,7 @@ Options:
   -c, --config <value...>                                                            Provide path to a webpack configuration file e.g. ./webpack.config.js.
   --config-name <value...>                                                           Name of the configuration to use.
   -m, --merge                                                                        Merge two or more configurations using 'webpack-merge'.
-  --config-registered                                                                Disable interpret a config file.
+  --disable-interpret                                                                Disable interpret a config file.
   --env <value...>                                                                   Environment passed to the configuration when it is a function.
   --node-env <value>                                                                 Sets process.env.NODE_ENV to the specified value.
   -h, --hot [value]                                                                  Enables Hot Module Replacement

@@ -175,7 +175,7 @@ type WebpackDevServerOptions = DevServerConfig &
     merge?: boolean;
     config: string[];
     configName?: string[];
-    configRegistered?: boolean;
+    disableInterpret?: boolean;
     argv: Argv;
   };
 

@@ -700,7 +700,7 @@ class WebpackCLI implements IWebpackCLI {
       "config",
       "config-name",
       "merge",
-      "config-registered",
+      "disable-interpret",
       "env",
       "mode",
       "watch",
@@ -751,7 +751,7 @@ class WebpackCLI implements IWebpackCLI {
         description: "Merge two or more configurations using 'webpack-merge'.",
       },
       {
-        name: "config-registered",
+        name: "disable-interpret",
         configs: [
           {
             type: "boolean",
@@ -1817,15 +1817,15 @@ class WebpackCLI implements IWebpackCLI {
   }
 
   async loadConfig(options: Partial<WebpackDevServerOptions>) {
-    const configRegistered =
-      typeof options.configRegistered !== undefined && options.configRegistered;
+    const disableInterpret =
+      typeof options.disableInterpret !== undefined && options.disableInterpret;
 
     const interpret = require("interpret");
     const loadConfigByPath = async (configPath: string, argv: Argv = {}) => {
       const ext = path.extname(configPath);
       const interpreted = Object.keys(interpret.jsVariants).find((variant) => variant === ext);
 
-      if (interpreted && !configRegistered) {
+      if (interpreted && !disableInterpret) {
         const rechoir: Rechoir = require("rechoir");
 
         try {
@@ -1917,7 +1917,7 @@ class WebpackCLI implements IWebpackCLI {
       path: new WeakMap(),
     };
 
-    if (options.config && options.config.length > 0 && configRegistered) {
+    if (options.config && options.config.length > 0 && disableInterpret) {
       const loadedConfigs = await Promise.all(
         options.config.map((configPath: string) =>
           loadConfigByPath(path.resolve(configPath), options.argv),

@@ -16,13 +16,13 @@ describe("webpack cli", () => {
     expect(existsSync(resolve(__dirname, "dist/foo.bundle.js"))).toBeTruthy();
   });
 
-  it('should work with the "config-registered" option from flags', async () => {
+  it('should work with the "disable-interpret" option from flags', async () => {
     const configFileName = "webpack.config";
     const configFilePath = resolve(__dirname, `${configFileName}.ts`);
     const buildScripts = spawnSync("yarn", ["tsc", configFilePath]);
     expect(buildScripts.stdout).toBeTruthy();
 
-    const { exitCode, stderr, stdout } = await run(__dirname, ["--config-registered"]);
+    const { exitCode, stderr, stdout } = await run(__dirname, ["--disable-interpret"]);
     unlinkSync(resolve(__dirname, `${configFileName}.js`));
 
     expect(stderr).toBeFalsy();