refactor!: remove workarounds for the webpack v4 support #3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
approved these changes
Jul 20, 2022
Codecov Report
@@ Coverage Diff @@
## next #3346 +/- ##
==========================================
+ Coverage 92.11% 93.05% +0.93%
==========================================
Files 22 22
Lines 1713 1685 -28
Branches 511 490 -21
==========================================
- Hits 1578 1568 -10
+ Misses 135 117 -18
Continue to review full report at Codecov.
|
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
alexander-akait
approved these changes
Jul 25, 2022
snitin315
added a commit
that referenced
this pull request
Jul 25, 2022
snitin315
added a commit
that referenced
this pull request
Sep 10, 2022
snitin315
added a commit
that referenced
this pull request
Sep 17, 2022
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
snitin315
added a commit
that referenced
this pull request
Oct 8, 2022
snitin315
added a commit
that referenced
this pull request
Oct 22, 2022
snitin315
added a commit
that referenced
this pull request
Nov 6, 2022
snitin315
added a commit
that referenced
this pull request
Nov 8, 2022
alexander-akait
pushed a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Already present.
If relevant, did you update the documentation?
No.
Summary
Remove workarounds for the webpack v4 support.
Does this PR introduce a breaking change?
Yes
Other information
No