refactor: simplify for loops to for...of in Server.js #5496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client-src/index.js
Outdated
| for (let i = 0; i < printableErrors.length; i++) { | ||
| log.error(printableErrors[i]); | ||
| for (const printableError of printableErrors) { | ||
| log.error(printableError); |
There was a problem hiding this comment.
Please do not touch this file because it can be used in very old browsers
There was a problem hiding this comment.
@alexander-akait
Ok, I've reverted the index.js fix.
alexander-akait
approved these changes
May 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5496 +/- ##
==========================================
- Coverage 90.29% 83.37% -6.93%
==========================================
Files 15 13 -2
Lines 1577 2027 +450
Branches 601 745 +144
==========================================
+ Hits 1424 1690 +266
- Misses 140 303 +163
- Partials 13 34 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
simplify for loops to for...of in Server.js
Breaking Changes
no
Additional Info
no