-
-
Notifications
You must be signed in to change notification settings - Fork 387
ci(jest): run tests in an explicit environment #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@michael-ciniawsky need investigate |
We ideally should do this is our boilerplate since this will fail for each and every repo, but I would like to eventually overhaul the boilerplate beforehand (simplify it). Yeah the test failure seems to be real, I try to look at it but not familiar with the test here atm :) |
@michael-ciniawsky ping me when you investigate |
Also better use https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/jest.config.js file to with |
I didn't find the correct name in the Jest Docs for adding this to the config file, will update |
jest --env node
)
Something is really at odds with the CI, all test pass locally ( /home/circleci/project/src/index.js
8:8 error Replace `·Template,·util:·{·createHash·}·` with `⏎··Template,⏎··util:·{·createHash·},⏎` prettier/prettier
100:10 error Replace `{·dependencies:·[dependency]·},·callback` with `⏎····{⏎······dependencies:·[dependency],⏎····},⏎····callback⏎··` prettier/prettier |
@michael-ciniawsky use |
The problem is I don't get anything to fix on my machine 🙃 |
Type
Issues
SemVer