Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(jest): run tests in an explicit environment #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nuc
Copy link

@nuc nuc commented Aug 29, 2018

This PR contains a:

  • bugfix

Motivation / Use-Case

Currently tests are broken on CircleCI.

Breaking Changes

Nop.

Additional Info

None.

@jsf-clabot
Copy link

jsf-clabot commented Aug 29, 2018

CLA assistant check
All committers have signed the CLA.

@alexander-akait
Copy link
Member

@nuc looks your PR is not fix problem

@nuc
Copy link
Author

nuc commented Aug 29, 2018

@evilebottnawi I pushed again. Apparently, eslint --fix doesn't really fix the problem.

Waiting for CircleCi.

@nuc
Copy link
Author

nuc commented Aug 29, 2018

So, seems that the test manage to run now, but there are a couple of failed test cases.

Interestingly enough, they don't fail locally.

@evilebottnawi do you have any ideas how to proceed?

@alexander-akait
Copy link
Member

@nuc need investigate, feel free go ahead, don't have time on this week for this, sorry, btw thanks for work

@michael-ciniawsky michael-ciniawsky changed the title fix(test): provide testEnvironment for jest test(jest): run tests in an explicit environment (testEnvironment) Aug 29, 2018
@nuc
Copy link
Author

nuc commented Aug 30, 2018

We can maybe consider this PR done, since it's about allowing the tests to run again on CircleCI, rather than fixing the broken cases.

@jahed jahed mentioned this pull request Sep 1, 2018
2 tasks
@michael-ciniawsky michael-ciniawsky changed the title test(jest): run tests in an explicit environment (testEnvironment) test(jest): run tests in an explicit environment Sep 1, 2018
@michael-ciniawsky michael-ciniawsky removed this from the 0.4.3 milestone Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants