Strip topic name when formatting RPL_HELPSTART/RPL_HELPTXT/RPL_ENDOFHELP/ERR_HELPNOTFOUND - #1772
Closed
progval wants to merge 2 commits into
Closed
Strip topic name when formatting RPL_HELPSTART/RPL_HELPTXT/RPL_ENDOFHELP/ERR_HELPNOTFOUND#1772progval wants to merge 2 commits into
progval wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
- Coverage 37.99% 37.99% -0.01%
==========================================
Files 210 210
Lines 85271 85280 +9
==========================================
Hits 32401 32401
- Misses 52870 52879 +9
Continue to review full report at Codecov.
|
Member
|
Hi, |
Contributor
Author
|
IIRC that was on irc.ergo.chat/6697 when typing |
flashcode
pushed a commit
that referenced
this pull request
Jul 2, 2022
flashcode
pushed a commit
that referenced
this pull request
Jul 2, 2022
flashcode
added a commit
that referenced
this pull request
Jul 2, 2022
flashcode
added a commit
that referenced
this pull request
Jul 2, 2022
flashcode
added a commit
that referenced
this pull request
Jul 2, 2022
flashcode
added a commit
that referenced
this pull request
Jul 2, 2022
flashcode
added a commit
that referenced
this pull request
Jul 2, 2022
Member
|
Thanks, merged. I added unit tests on these messages 524/704/705/706 (and found a bug with hook_print callback not called on empty messages, fixed as well). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, when using
/quote help modeon Ergo:Before:
After: