Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Changed mins into hours in const hour #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ChielHackman
Copy link

Hi Wes.

I felt free to fix a small typo/bug. Also send you an email about this a few minutes ago.

@dandenney
Copy link

dandenney commented Dec 10, 2016

I already forked the repo and have commits for my dailies, but I believe the divisor for hours needs to be 24 as well.

const hourDegrees = ((hours / 24) * 360) + 90;

This was wrong, my bad!

@hiscc
Copy link

hiscc commented Dec 11, 2016

hey dandenney , but where is the hourhand's position when it is twelve o'clock? 🙂

@ghost ghost mentioned this pull request Dec 11, 2016
@dandenney
Copy link

@ManInBoat Yeah, you're right. I popped in 12 and it points to 6 at that point.

@beausmith beausmith mentioned this pull request Dec 14, 2016
@wesbos
Copy link
Owner

wesbos commented Dec 14, 2016

Fixed in #49

@wesbos wesbos closed this Dec 14, 2016
saury pushed a commit to saury/JavaScript30 that referenced this pull request Dec 30, 2016
YuriBrunetto added a commit to YuriBrunetto/JavaScript30 that referenced this pull request Jan 3, 2017
jdstein1 added a commit to jdstein1/JavaScript30 that referenced this pull request Jan 10, 2017
sgromskiy pushed a commit to sgromskiy/JavaScript30 that referenced this pull request Mar 7, 2017
kdipaolo added a commit to kdipaolo/JavaScript30 that referenced this pull request Apr 6, 2017
LeiG added a commit to LeiG/JavaScript30 that referenced this pull request Jul 4, 2017
jdlawrence added a commit to jdlawrence/JavaScript30 that referenced this pull request Jul 28, 2017
JeffDess added a commit to JeffDess/JavaScript30 that referenced this pull request Sep 19, 2017
ShimmiChristo added a commit to ShimmiChristo/JavaScript30 that referenced this pull request Sep 19, 2017
@DawnM DawnM mentioned this pull request Nov 2, 2017
austinjreilly added a commit to austinjreilly/JavaScript30 that referenced this pull request Nov 29, 2017
smchenrybc added a commit to smchenrybc/JavaScript30 that referenced this pull request Jul 30, 2018
Watson6982 added a commit to lgss/JavaScript30 that referenced this pull request Sep 16, 2018
brandonjunus added a commit to brandonjunus/JavaScript30 that referenced this pull request Jan 13, 2019
brandonjunus added a commit to brandonjunus/JavaScript30 that referenced this pull request Jan 13, 2019
tiago-m-dias added a commit to tiago-m-dias/JavaScript30 that referenced this pull request Apr 27, 2019
Challenge wesbos#16 Mouse movement with shadow
mochibot pushed a commit to mochibot/JavaScript30 that referenced this pull request Jun 18, 2019
Sebsterio added a commit to Sebsterio/JavaScript30 that referenced this pull request Dec 16, 2019
AlexJoeb pushed a commit to AlexJoeb/JavaScript30 that referenced this pull request Mar 29, 2020
DeonJordaan added a commit to DeonJordaan/JavaScript30 that referenced this pull request Jun 16, 2021
bhaveshgoyal182 pushed a commit to bhaveshgoyal182/JavaScript30 that referenced this pull request Jul 4, 2021
ArtEnsemble added a commit to ArtEnsemble/JavaScript30 that referenced this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants