Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Maintain Code Consistency With Video Lesson (Array Cardio Practice - Day 1) #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Eduardo06sp
Copy link
Contributor

@Eduardo06sp Eduardo06sp commented Apr 17, 2021

While watching the lesson video JavaScript Array Cardio Practice - Day 1, I noticed that problem 4 gave me unexpected results (where you calculate the total ages). I also noticed a few people in the comments were having the same issue.

So I dug deeper and noticed there were some additions to the inventors array that were not reflected in the video.
One of the first rules for contributing here:

These files are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things or fixed a small bug, that is great great, but I will be keeping them the same as the videos to avoid confusing.

So for the sake of consistency and avoiding confusion for newcomers following along, I believe it's best to revert these commits.

@wesbos wesbos closed this Mar 7, 2025
@wesbos
Copy link
Owner

wesbos commented Mar 7, 2025

nah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants