SFrame V3 MVP#1898
Draft
mati865 wants to merge 7 commits into
Draft
Conversation
|
I just ran into this when I updated Arch. I'm using binutils 2.46.0. This branch seems to work fine for me. Please let me know if you want me to debug anymore/upload an artifact or whatnot. The test script works just fine: |
Member
Author
|
@macmv you won't see SFrame issue on main branch, Wild will just discard This PR is on hold until glibc fixes/implements SFrame v3 support, so it can be reasonably tested. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits starting with
updateandaccountare what https://sourceware.org/binutils/docs-2.46/sframe-spec.html#Changes-from-Version-2-to-Version-3 is about.Just like ld.bfd did, this change drops support for SFrame V2 due to how annoying it would be to support both formats at the same time, and the fact that the decisions by the distros to enable SFrame V2 by default were short-lived.
At the time of writing this description, glibc still can only read SFrame V2 (the changes are lingering on the mailing list), so I'm posting this as a draft. Hopefully it doesn't take too long from now before we can test it on the CI.
Can be tested with https://gist.github.com/mati865/5d5fead3a7cbefcbe9a609274a0d27eb if your system has Binutils 2.46.
This PR only ports existing code from SFrame V2 to V3. It doesn't add new
SFRAME_FDE_TYPE_FLEXorSFRAME_FDE_TYPE_DEFAULT.Fixes #1576