Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Forward command line arguments for console launchers #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2025

Conversation

firai
Copy link
Contributor

@firai firai commented Apr 25, 2025

Fixes #1564 for console launchers

@stonebig
Copy link
Contributor

stonebig commented Apr 25, 2025

Waaaa, it's seems to resolve the sad regression:

  • would you just remove the binaries ? (will do from my environment)
  • I see it works on launcher_template_WINDOWS.cpp too ... Can you add it ? otherwise I'll do after

@firai
Copy link
Contributor Author

firai commented Apr 25, 2025

I reverted replacing the binaries.

For the window launcher, adding the same code technically forwards the command line arguments, but I'm getting different behavior between & '.\IDLE (Python GUI).exe' <path> from a command prompt, .\scripts\winidle.bat <path> from a command prompt and drag-and-drop onto the IDLE launcher, so

I submitted it as a separate PR (#1572). I think I fixed the previous issues.

@stonebig stonebig added this to the 2025-03 PEP 751 / AI local milestone Apr 25, 2025
@firai firai marked this pull request as draft April 25, 2025 17:00
@firai firai marked this pull request as ready for review April 25, 2025 17:29
@firai firai mentioned this pull request May 9, 2025
@stonebig stonebig merged commit 12f5771 into winpython:master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launchers don't forward command line arguments to batch scripts
2 participants