@georgejean tweaks for powershell #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgejean
reviewed
Nov 22, 2016
| @@ -719,12 +720,13 @@ def _create_batch_scripts_initial(self): | |||
| self.create_batch_script('cmd_ps.bat', r"""@echo off | |||
| rem safe bet | |||
| call "%~dp0env_for_icons.bat" | |||
| Powershell.exe -executionpolicy RemoteSigned -noexit -file "%~dp0WinPython_PS_Prompt.ps1" | |||
| Powershell.exe -Command "& {Start-Process PowerShell.exe -ArgumentList '-ExecutionPolicy RemoteSigned -noexit -File""%~dp0WinPython_PS_Prompt.ps1""'}" | |||
| """) | |||
There was a problem hiding this comment.
II think exit must be inserted on this line (line above 724) in order to exit the cmd.exe (the powershell console remains open), see line 729.
There was a problem hiding this comment.
oups ! I forgot it
There was a problem hiding this comment.
but it seems not needed
There was a problem hiding this comment.
maybe you're right... in doubts, I add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#436