Support for xml namespaces in XPathMatcher #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
reviewed
Sep 29, 2023
StefH
reviewed
Sep 29, 2023
StefH
requested changes
Sep 29, 2023
|
@cal-schleupen I did add some review comments, can you please take a look? |
|
Hi Stef, thanks a lot for reviewing it so fast! I'm really impressed and I like WireMock.NET a lot. It is also well done under the hood. This weekend I am a little bit busy with my family, but I'll fix it not later than on Monday. Hopefully today ;-) I am really happy that you could take a look at my pull request! Kind regards, |
StefH
reviewed
Oct 2, 2023
StefH
reviewed
Oct 2, 2023
StefH
reviewed
Oct 2, 2023
StefH
reviewed
Oct 2, 2023
|
Maybe we got it now ;-) |
StefH
approved these changes
Oct 2, 2023
|
@cal-schleupen I'll merge this and create a new NuGet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have round about 4800 WCF Services in our landscape, thus this faker is really helpful. In order to write more easy request body matchers I would like to write more easy xpath expressions using the xpath matcher as follows:
{ "Title": "wcf test", "Request": { "Path": { "Matchers": [ { "Name": "WildcardMatcher", "Pattern": "/MyService.svc" } ] }, "Methods": [ "post" ], "Headers": [ { "Name": "Content-Type", "Matchers": [ { "Name": "WildcardMatcher", "Pattern": "text/xml; charset=utf-8", "IgnoreCase": true } ], "IgnoreCase": true }, { "Name": "SOAPAction", "Matchers": [ { "Name": "WildcardMatcher", "Pattern": "*urn://MyService/Query*", "IgnoreCase": true } ], "IgnoreCase": true } ], "Body": { "Matcher": { "Name": "XPathMatcher", "Pattern": "/s:Envelope/s:Body/q:QueryRequest", "XmlNamespaceMap": [ { "Prefix": "s", "Uri": "http://schemas.xmlsoap.org/soap/envelope/" }, { "Prefix": "i", "Uri": "http://www.w3.org/2001/XMLSchema-instance" }, { "Prefix": "q", "Uri": "urn://Schleupen.AS.MT.BIB.Buecher.BuchQueryService_3.1" } ] } } }, "Response": { "StatusCode": 200, "Body": "<s:Envelope xmlns:s=\"http://schemas.xmlsoap.org/soap/envelope/\"><s:Body><QueryResponse xmlns=\"urn://MyService\"></QueryResponse></s:Body></s:Envelope>", "Headers": { "Content-Type": "text/xml" } } }This implementation handles this so that
matches for example.
Yes, I can use 'local-name()' etc. but I think this way it is more easy.