Add a configuration option to allow a 403 response buffer request #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update http-auth-interceptor to use the new response interceptors. The current way is deprecated.
Described how to use the config updater function in an Advanced use case section. Have not changed anything, just added.
Updated README with configUpdater description
Fix a typo
More documentation for loginConfirmed (#56)
Added support for HTTP 403 responses
Added specific detail to the advanced use cases to make them more clear.
At the very least include how to use this module. It's an awesome module, but extremely confusing documentation.
Clarified Advanced Use cases
Update README.md
Fix link to blog
- Spelling correction
Added information about the ignoreAuthModule config flag to the manual
add bower module name
Update README.md
Update bower.json to match current release
Per bower/spec@a325da3 Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property
Remove moot `version` property from bower.json
…into tamlyn-master Conflicts: package.json
|
What is that? A 41 commits long pull request? |
|
Sorry Witold, i do a pull request with wrong commits, you can solve this? |
|
I don't think so, it is your pull request. You can try if you can change target branch or if not, discard this and create new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a line configuration for the interceptor allows me to set up or not, buffer a request if a response returns me 403, and resend it after the user login. Similarly it happens with the error code 401.
There are servers that return 403 or API, when a token is expired. And it is highly questionable whether to return 401 or 403, so I think the configuration is correct.
So i change this:
to: