forked from postgres/postgres
-
Notifications
You must be signed in to change notification settings - Fork 0
merge zheap to 894f5de fow show all commit #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wjzeng
wants to merge
17
commits into
REL_13_beta3_894f5de_merge_zheap
Choose a base branch
from
REL_13_ZHEAP
base: REL_13_beta3_894f5de_merge_zheap
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a *TEMPORAL WORKING* repository for ZHEAP upgrading, which developing branch is `REL_13_ZHEAP`. The original ZHEAP repository doesn't consider version upgrades. Therefore, upgrade work will be done in this temporary repository. In the future, we plan to merge it with the ZHEAP repository.
The optimization code been added by the commit 695c597 to optimize this function. However, due to this effect, when CREATE or ALTER TABLE statement is issued in a transaction block and then ROLLBACK is issued, the postgres server is crushed. The reason is that ROLLBACK statement invokes HeapTupleSatisfiesMVCC() and it calls HeapTupleHeaderGetCmin() and GetRealCmin(), then Segmentation fault is occurred. To avoid this issue, we comment out this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.