NvmFlash: fix using state.count when state.count is not valid #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
requested changes
Sep 18, 2025
Contributor
bigbrett
left a comment
There was a problem hiding this comment.
Great fix, great test additions - just need to rework how we simulate the failure without modifying the internals of the library with instrumentation
billphipps
approved these changes
Sep 24, 2025
jackctj117
pushed a commit
to jackctj117/wolfHSM
that referenced
this pull request
Sep 24, 2025
…L#175) * nvm_flash: fix using state.count when is not valid * wh_flash_ramsim: add support for simulating failures * test: nvm_flash: add test for recovery mechanism * test: add flash cb wrapper to inject failures * test: use fault injection to test recovery * Revert "wh_flash_ramsim: add support for simulating failures" This reverts commit a0f38f2. * wolfhsm: test: fix bad assert conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.