Thanks to visit codestin.com
Credit goes to github.com

Skip to content

crypto: aesctr: fix: use correct buffer size in memcpy for tmp #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigbrett merged 1 commit into from
Sep 24, 2025
Merged

crypto: aesctr: fix: use correct buffer size in memcpy for tmp #183

bigbrett merged 1 commit into from
Sep 24, 2025

Conversation

@rizlik
Copy link
Contributor

@rizlik rizlik commented Sep 24, 2025

I'm puzzled how static analysis or ASAN can miss this.
At least for ASAN, I think the reason is that the Aes struct is big enough to don't overflow the struct.
making the struct smaller by removing HAVE_AES_GCM triggers an error immediately at compile time with clang

clang  -std=c90 -Werror -Wall -Wextra -ffunction-sections -fdata-sections -ggdb -g3 -fsanitize=address -D_POSIX_C_SOURCE=200809L -DWOLFSSL_USER_SETTINGS -DWOLFHSM_CFG -DWOLFHSM_CFG_TEST_POSIX -DWOLFHSM_CFG_DMA -DWOLFHSM_CFG_ENABLE_CLIENT -DWOLFHSM_CFG_ENABLE_SERVER -DWOLFHSM_CFG_IS_TEST_SERVER -I. -I./config -I../../wolfssl -I../ -I..//port/posix -c -o Build/wh_server_crypto.o ..//src/wh_server_crypto.c
..//src/wh_server_crypto.c:1374:13: error: 'memcpy' will always overflow; destination buffer has size 160, but size argument is 256 [-Werror,-Wfortify-source]
 1374 |             memcpy(aes->tmp, tmp, AES_MAX_KEY_SIZE);
      |             ^
1 error generated.

@rizlik rizlik requested review from bigbrett and miyazakh September 24, 2025 10:50
@miyazakh
Copy link
Contributor

miyazakh commented Sep 24, 2025

Thanks for the fix.

@bigbrett bigbrett merged commit c81701c into wolfSSL:main Sep 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigbrett bigbrett bigbrett approved these changes

@miyazakh miyazakh miyazakh approved these changes

Assignees

@bigbrett bigbrett

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rizlik @miyazakh @bigbrett