-
Notifications
You must be signed in to change notification settings - Fork 25
Added code coverage feature #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds code coverage functionality to the test suite using gcovr. The implementation provides both automated and manual workflows for generating coverage reports in various formats (HTML, XML, JSON) with customizable filtering and threshold options.
- Added gcovr-based code coverage support with compiler instrumentation flags
- Implemented convenient
make coveragetarget for automated coverage workflow - Added comprehensive documentation with installation, usage, and customization examples
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Makefile | Added coverage build flags, clean targets for coverage files, and automated coverage target |
| test/README.md | Added detailed documentation covering installation, usage, and configuration options for code coverage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
afce879 to
5331d04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackctj117 when I run make coverage this is the coverage report I see generated

This doesn't seem right? From the build output:
Generating coverage report...
cd .. && mkdir -p coverage && gcovr --root . \
--filter 'src/.*' \
--filter 'wolfhsm/.*' \
--html-details coverage/index.html \
--print-summary
lines: 0.0% (0 out of 0)
branches: 0.0% (0 out of 0)
Added gcovr code coverage for tests