DMA support for CMAC #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billphipps
requested changes
Mar 27, 2025
Contributor
billphipps
left a comment
There was a problem hiding this comment.
Excellent that you were able to put this together so quickly, but I think we need to clean up the CMAC state handling by passing the necessary contents instead of the whole struct.
…ient memory, fix bug due to improper cmac resumption
billphipps
previously approved these changes
Mar 31, 2025
Contributor
billphipps
left a comment
There was a problem hiding this comment.
Lemme know if you need to remove the dead code I noted. Ok if you want to keep it since you are adding more stuff in the future.
Co-authored-by: Bill Phipps <[email protected]>
billphipps
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DMA support for CMAC. Can be used via ANY of wolfCrypt's CMAC APIs that accept a devId.
Passes wolfHSM and wolfCrypt tests on both POSIX sim and TC3xx.
A bit of a noisy diff, as I ran clang-format on some bigger blocks of code.
Future work: